Levi Morrison
Levi Morrison
There are two variants commonly found: `qsort_r` and `qsort_s`. Sadly the APIs aren't quite the same even though they are supporting the same idea: add a context parameter. Perhaps we...
As mentioned on another ticket it might be good to extract the `equals` method into an `Equatable` interface which `Hashable` extends from. I'm not sure collections should be `Hashable` but...
> Usually an Equatable, Equalable, Identifiable, … interface goes hand in hand with the hash method because they actually just compare the hashes of the objects. I'm not sure where...
> Also, as explained in #67, lhs.equals(rhs) does not imply lhs.hash == rhs.hash for all types, only for most. Can you directly link me to the explanation? I see some...
Floating point values are not objects, do not implement Hashable, and thus do not have an `equals` method. While INF and NAN semantics are something to be aware of it's...
Any feedback on this idea? Obviously this would need accompanying work in the extension.
Thanks for the report! We'll definitely take a look at this soon.
I've addressed some of the low hanging fruit since I had a moment, but the sigsegv will have to be looked at later. Thanks again for the report.
@bwoebi, I can reproduce a sigsegv during building the Dockerfile: ``` FROM php:8.1.2 RUN apt update RUN curl -LO https://github.com/DataDog/dd-trace-php/releases/download/0.79.0/datadog-setup.php && php datadog-setup.php --php-bin=all RUN apt install -y wget git...
A possibly important finding: I did not crash on `php:8.1.10`. Of course, sometimes things just _subtly_ change and it hides the issue, rather than something being fixed. I also didn't...