Levi Morrison comments

Repositories
Issues
Comments

Results 125 comments of


                                            Levi Morrison

feat: enum.merge_generic_tags

It seems like I've fixed the compatibility with prefixing, though there should be tests added for it. When running it on my real codebase, I get a duplicate struct, a...

feat: enum.merge_generic_tags

I've added tests, still having an issue with my real-world case and finding a sharable reproducer. Edit: the real-world issue was a mistake in that code after all! This is...

feat: enum.merge_generic_tags

I've squashed Ben's commits, and my own, so this can go cleanly into master once reviewed.

Feature: `HashTable::try_insert_unique_within_capacity`

I think the idea to keep a safe API and use `hint::unreachable_unchecked()` in the caller is a good one. I've opened a PR and verified that it's no-panic compatible.

Feature: `HashTable::try_insert_unique_within_capacity`

I think it should be renamed `try_insert_unique_within_capacity`. I'll update the PR too.