Fredrik Medley

Results 29 comments of Fredrik Medley

> * It might be more expense to build the digest map even when the cache is disabled. The execution time increase I would expect is due to the recursive...

To avoid checking the API version, the response can also have a `bool uses_indices`.

Nice and simple suggestion, Eric! A simple implementation would be ```python SortedMap files HashSet visitedDirectories def visitDirectory(rootPath, rootDigest) { if not visitedDirectories.put(rootDigest).existed_since_before { directoryMessage = cas.getDirectory(rootDigest) for subPath, subDigest in...

The implementation I've done in Bazel, https://github.com/moroten/bazel/blob/c01401f38ec9ed7122a53ee9d4cc673b30ba590b/src/main/java/com/google/devtools/build/lib/remote/FastInputKeyCache.java#L51-L91 (_Add fast cache check for remote execution_) on https://github.com/moroten/bazel/tree/optimize-remote-execution, views a depset as a directed acyclic graph and memoizes the digest of each...

@HALtheWise Interesting XOR hash suggestion! When checking the cache, only the root hash is needed which could benefit of the faster calculation. One could still keep the requirement of uploading...

Making the test environment independent of the production code is also what we have been striving for. That makes it possible to change the CI infrastructure without having to update...

This suggestion is basically the opposite of https://github.com/bazelbuild/remote-apis/issues/144. Note that the Remote Asset API fetch response contains some additional fields compared to the `ActionResult`. One can put that information into...

@EdSchouten, do you have a fresh rebase for this patch?

I have a similar problem where the test times differ a lot between configurations (release/debug/sanitize) and platform (Linux/Windows). In my case, allowing `select()` to set the timeout would be enough....