Morgan Aldridge comments

Results 146 comments of


                                            Morgan Aldridge

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

I have fixed a possible uninitialized argument value in `misc.c`'s `ReadIcon()`.

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

I have fixed all the potential dereference of null pointer values in `menu.c`'s `press_menu()` & `ChoiseMenu()`.

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

Fixed a dereference of null pointer in `misc.c`'s `RaiseMlvwmWindow()`.

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

Fixed "allocator sizeof operand mismatch" bugs in `config.c` & `mlvwm.c` where `calloc()` was being used to accidentally allocate memory for a number of `MlvwmWindow`s instead of just a number of...

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

Fixed potential garbage return value in `event.c`'s `NextActiveWin()`, which is the last bug identified by clang's `scan-build` that I intend to fix at this time. The remaining "dead assignment" bugs...

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

I'm going to test this branch for a bit before merging it.

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

Clang was warning about an unused `lp` variable in `menus.c`'s `RedrawMenuBar()` at compile time (not `scan-build`), so I figured I'd address it here as well.

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

There are a couple more compile warnings that I'd like to address now too (related to Issue #6, replacing `sprintf()` with `snprintf()`): ``` mlvwm.c:386(mlvwm.o:(Done)): warning: strcpy() is almost always misused,...

Fix bugs identified by running clang's `scan-build-16` on the MLVWM source

I also took this opportunity to correct the spelling of `ChoiseMenu()` to `ChooseMenu()` in `functions.c` & `menus.c`.

`Style` commands don't search `WM_WINDOW_ROLE` X window properties

Looking at this again for another [mlvwmrc](https://github.com/morgant/mlvwmrc) issue and wanted to note the following for future me: * Parsing of `Style ... END` configuration blocks is implemented in `config.c`'s `SetStyles()`....