Gary comments

Repositories
Issues
Comments

Results 4 comments of


                                            Gary

AssertFilter does not ignore the assert statement

I've implemented a solution in a pull request: https://github.com/jacoco/jacoco/pull/1379 Please take a look at the pull request, which contains screenshots of the implemented solution and a very similar alternative solution.

AssertFilter does not ignore the assert statement

I'm not sure what else they want. I've modified the existing test expectations. In the comment of the AssertTarget.java assert line, and in the unit test AssertFilterTest.java

ignore the assert statement's conditional branch. (#1378)

before fix: after fix:

ignore the assert statement's conditional branch. (#1378)

An alternative solution to AssertFilter: 62 ` output.ignore(start, ((JumpInsnNode) cursor).label); ` results in this report, where they're not even considered coverage lines: