Morgan Chen

Results 271 comments of Morgan Chen

Thanks, this is very helpful. This line ``` Invalid type in JSON write (NSURLError) ``` suggests that the value passed into `+[NSJSONSerialization dataWithJSONObject:options:error:]` by `HyperSDK` contains a type that cannot...

It turns out my last comment was wrong and Performance [does not call any JSON serializer methods](https://cs.opensource.google/search?q=%22dataWithJSONObject%22&ss=firebase-sdk%2Ffirebase-ios-sdk). You should contact the HyperSDK vendor and tell them to fix this issue...

Can you `pod update --verbose` to get a more detailed error on the pod that's failing to install?

In our discussion, we weighed the benefits of pushing the changes in 9.0 vs accumulating technical debt for the deprecation, and decided that we could achieve a smoother 9.0 release...

Hey @Kaspik, I built PromisesObjC with clang's `-ftime-trace` and found that all of the files that took a while in your screenshot built in ~100ms. I did this via CocoaPods...

I compiled the entire project (performance traces are generated per-file). The package manager should not affect the compile times, but I can try again with SPM if you'd like.

@MartinStrambach, have you tried compiling your project with the `-ftime-trace` flag to identify bottlenecks in the built dependencies? Our investigation suggests Xcode is including time spent waiting to compile a...

iirc it's supposed to display your app icon, though I'm not sure where this gets specified. @dmandar can you clarify? I'll update the docs [here](https://firebase.google.com/docs/dynamic-links/link-previews) once we get an answer.

This crash is a result of watchdog termination during Crashlytics initialization. The `dispatch_group_wait` that caused this crash is [here](https://cs.opensource.google/firebase-sdk/firebase-ios-sdk/+/master:Crashlytics/Crashlytics/Components/FIRCLSContext.m;l=234?q=FIRCLSContextInitialize). Crashlytics uses a timeout to skip init and error out if...