Results 84 comments of Matt Morehouse

On my machine, here's the failure output: ``` ============================= test session starts ============================== platform linux -- Python 3.8.10, pytest-7.1.2, pluggy-1.0.0 -- /home/matt/.cache/pypoetry/virtualenvs/cln-meta-project-dfJtkWA4-py3.8/bin/python3 cachedir: .pytest_cache rootdir: /home/matt/Code/morehouse/lightning plugins: xdist-2.5.0, custom-exit-code-0.3.0, forked-1.4.0,...

> I think both lines `bitcoind.generate_block(100)` are obsolete and can be deleted. After a (successful) `close` command, the channel state is already `CLOSINGD_COMPLETE` Done in updated patch. > > >...

Hi folks. I've quit my day job and am interested in working on this. @niftynei's spec for [liquidity ads](https://github.com/lightning/bolts/pull/878) seems to be shelved until the [dual funding](https://github.com/lightning/bolts/pull/851) spec is finalized...

I'm still working through the implementation/testing details, but here's some ideas I have so far. Feedback is appreciated. ## Funding Manager The funding manager needs to handle all the new...

### Handling Failures #### Before we sent `tx_signatures` We simply remove any wallet reservation and related context, sending an error as a courtesy. We can use `failFundingFlow` for this. ####...

### RBF We should support RBF replacement of pending channels until they confirm. This feature is not necessary for the MVP, but thinking about it now may influence other aspects...

## Misc ### Dual Funding Policies I propose the following initial (experimental) config parameters for handling dual funding requests: - `dualfund.active=true` - if true, LND will advertise the `option_dual_fund` feature...

## Implementation & Testing Plan To simplify code review, I propose we break the implementation into 5 major PRs: 1. Open & Accept v2 2. Interactive Tx Construction 3. Signature...

@Roasbeef: Thanks for your thoughts and advice. > As a result, I think we either need to commit early on to do aggressively refactoring, or chose to explicitly leave it...

Can we rebase and merge this? I'm want to write fuzz tests for the new [dual funding](https://github.com/lightning/bolts/pull/851) messages, but `make fuzz-build` is still broken.