Mike O'Regan

BuiltinFunctions::ProhibitUselessTopic dies on eval expression with require

2

A test case boiled down from the svg-svg2zinc-0.10 distribution: ``` $ cat test.pm eval ( require X ); $ perlcritic -s BuiltinFunctions::ProhibitUselessTopic test.pm Fatal error while critiquing "test.pm": Not an...

Perl::Critic::Utils::shebang_line() fooled by script that begins with Unicode byte order mark

6

In P::C 1.121, shebang_line() expects the first element in the Perl::Critic::Document to be the shebang line comment, so it will return false if the shebang is preceded by a Unicode...

Cmp document functions

2

Add t::lib::PPI::Test::CMP, containing the cmp_document family of testing functions, plus conversion of one .t file to use them. This is the last of the material from the old cmp_document branch....

cmp_document branch

4

Reorganize t/lib modules so that names to not conflict with lib/\* modules under use lib 't/lib'. Add t/lib/PPI/Test/pragmas.pm to centralize test file boilerplate. Add cmp_document family of test functions. As...

RT 41170: When token before ":" in a ternary expression is a bareword, it's misparsed as a label

1

Still an issue in 1.215: ``` ppidump '$foo = $condition ? undef : 1;' PPI::Document PPI::Statement [ 1, 1, 1 ] PPI::Token::Symbol '$foo' [ 1, 6, 6 ] PPI::Token::Operator '='...

PPI::Exception needs unit tests

2

There are currently no tests for PPI::Exception

RT 75921: match on implicit $_ after map/grep not recogized

2

https://rt.cpan.org/Public/Bug/Display.html?id=75921 PPI 1.215 does not recognize a match against implicit $_ that follows map/grep if the match does not include 'm': ``` ppidump 'map { 0 } /z/' PPI::Document PPI::Statement...

Why no 'use warnings' in PPI modules?

2

The test suite is careful to 'use warnings', but none of the PPI modules that get installed enable warnings. Any insight into the reasoning and/or experience that lead to not...

RFC: PPI::Exception subclasses -- use or toss?

4

PPI::Exception::ParserRejection and PPI::Exception::ParserTimeout exist in the source tree, but they are not used by PPI, and grep.cpan.me says they are not used on CPAN. Neither one adds anything to the...

Decide when require perl 5.6.2 to run PPI

2

Right now PPI requires perl 5.6.0. I put together (with some aggravation) a perlbrewed 5.6.2 to test with, but have no version earlier than that. cpantesters has tried pre-5.6.2 for...