Mark de Wever comments

Results 6 comments of


                                            Mark de Wever

[libc++] Introduce one-sided binary search for set_intersection so that it can be completed in sub-linear time for a large class of inputs.

Thanks for the patch. If I understand it right this might violate the complexity requirements in http://eel.is/c++draft/lower.bound#4. Is that correct?

[libc++] Introduce one-sided binary search for set_intersection so that it can be completed in sub-linear time for a large class of inputs.

> SGTM! I'll amend my submission, thanks! Great. As @philnik777 said we need to be careful about observable behaviour. I love to see performance improvements :-)

Improve the `__is_derived_from_optional` concept

Thanks, it seems I was a bit to aggressive removing code, https://godbolt.org/z/h5MxnxhYT works without modules and looks more like the original code. Thanks for finding the issue. I will investigate...

Improve the `__is_derived_from_optional` concept

I had a look and both `is_base_of` and `derived_from` take two template arguments. This one takes one argument and deduces the second argument. The trait also matches the wording in...

`<chrono>` `<format>`: `duration` formatting ignores precision

While implementing chrono formatting in libc++ I found no wording specifying the effect of precision option; so libc++ accepts it and ignores it. I agree it feels wrong. Investigating why...

declaration of 'something' with internal linkage cannot be exported

#568 should fix most of these issues, expect for the `static_asserts`.