Jason K. Moore
Jason K. Moore
Doesn't the 40 link pendulum not have any speed constraints? What are you checking in that case?
> I am unclear what changes I should submit. @smichr wrote "A test that catches this error should be added."
The test needs to be in the same PR as the change, i.e. this PR.
It doesn't need a new pr, but you can change the title to reflect what it has become.
> KanesMethod allows for linear speed constraints, however it does not check whether they really are linear. It does test the kinematic differential equations for linearity. So, I simply copied...
I recommend that these plots should be constructed with `sympy.plot` package and not manually with numpy/matplotlib. That way as `sympy.plot` improves (which it will drastically improve with on GSoC this...
> The reason for using Numpy and Matplotib is a very high computational advantage If you use this reasoning, then you should be using python-control not sympy for these things....
We did update the figure and I probably didn't update the text properly. I'll have a look. Thanks for reporting.
If it works from 1.1.0-1.3.0, I think we should make that the pin. It's best to support as wide a range as possible for general upstream dependency resolution. If it...
We should be clear whether this pin is for 1.12.1 only or if we plan to introduce it for SymPy >=1.13. If only for 1.12.1, Oscar ran the test suite...