Jason K. Moore
Jason K. Moore
I see many functions in there: https://github.com/csu-hmc/opty/blob/master/opty/utils.py
You can merge in master into this branch to remove all the commits from the first PR.
Make a unit test that shows the new options work in the three locations.
Do we have duplicate code in 3 places now with this PR?
If it is possible to have one location for the code and then reuse it in other places, that would be best. If you have time and the inclination to...
It's fine, but I don't recommend force pushing. When a review occurs in a PR, if you delete old commits you can't follow the review comments anymore because the code...
A single PR should contain both the changes to the code and a unit test to show your changes work. You only have the latter in this PR.
No, just fix this one!
You have an open PR here (26901) that is associated with your local branch named `test_linearity_of_speed...`. It only has the unit test as a change. Now add the code changes...
This has been reported here already: https://github.com/sympy/sympy/issues/26404