Matt Goo

Results 36 comments of Matt Goo

@rarous I don't think you need to transpile our files in `/dist`. I tried this in my own HTML/CSS setup using checkbox, and just including `@material/checkbox/dist/mdc.checkbox.js`. I also ran use...

I forgot we also have those files (sorry). And I see what you're saying. This will be a breaking change, but it doesn't make sense to have them in ES5...

@abhiomkar per ken's comment, it sounds like we should [support both ES5 & ES6 with ES Modules support](https://github.com/material-components/material-components-web/issues/4222). I'm not sure how we want to organize this. Some things I've...

Yes, we would need to add this file type, so it wouldn't be a breaking change for current users. It would technically increase developer's download times, but it would benefit...

Yes, this issue is to export ES6 classes along side the existing modules. So we would have UMD+ES5, ESM+ES5, and ESM+ES6.

I personally haven't used Jest, but take a look at how npm installed the `react-text-field` package in your node_modules directory. The `@material/textfield` package could be nested inside `@material/react-text-field/node_modules` directory. Also...

@rajzik have you figured out what regex worked for you?

have you tried https://github.com/facebook/create-react-app/issues/5241 - specifically inlining it as mentioned in [this comment](https://github.com/facebook/create-react-app/issues/5241#issuecomment-426986623)

Yes, especially for consistency that makes sense. I'll open one for that component

Need to keep in mind this [bug](https://github.com/material-components/material-components-web-react/issues/308) when fixing this issue.