Josselin Feist

Results 153 comments of Josselin Feist

Hi @y1cunhui, You can learn more about these issues through our blogposts: - https://blog.trailofbits.com/2018/09/05/contract-upgrade-anti-patterns/ - https://blog.trailofbits.com/2020/10/30/good-idea-bad-design-how-the-diamond-standard-falls-short/ - https://blog.trailofbits.com/2020/12/16/breaking-aave-upgradeability/ Every detector in `slither-check-upgradeability` has been built as a result of a...

@pcaversaccio: my bad; there were some timeout issues in the CI due to too many urls requests, so I just went ahead an re-run the recent PRs with failing actions...

Hi @CodeGodz. That's a good catch, thanks for reporting it. It looks like you're right and we should change the encoding in both Slither and crytic-compile

Currently the printer reports the constants where they are used, so if a constant is not used it is not reported. Do you need it to be reported in a...

Hi [man715](https://github.com/man715). Thanks for the work. It looks like you used two different emails for the commit, and one of them was not used to sign the CLA - as...

Tested with 0.8.3 - this is still present

Hi @axic , we fixed it with #1349, and the fix will be available in the upcoming release (same for https://github.com/crytic/slither/issues/1173)

Hi @revmischa , thank you for reporting this. I confirm that I can reproduce the bug with slither 0.8.3. @0xalpharush: can you look into the missing ternary operator?

@Bolee95 : it might be because of a cache issue in hardhat - it happens from time to time, where hardhat does not clean properly the compilation artefacts (despite slither...