Josselin Feist

Results 134 comments of Josselin Feist

Hi @mehrdadmms, awesome. I think it's mostly about reviewing https://github.com/crytic/slither/blob/master/slither/printers/inheritance/inheritance.py, and removing some of the misplaced `"\n"`

@pcaversaccio : we added more context in the detector wiki: https://github.com/crytic/slither/wiki/Detector-Documentation#recommendation-71

that's because the detector was not yet updated ;) We plan to update it for the upcoming release: https://github.com/crytic/slither/issues/1693

This makes sense to me, but I think we need to add a unit test for this

I think this needs more sync with the API provided by crytic-compile for the natspec. Ex: ```solidity % cat test.sol contract A{ /// @dev testdev /// @notice testnotice /// @param...

So I am not sure this should be something done on crytic-compile's side. As Echidna reads only the output from the solc format, we don't have a clean way to...

I think that if you set `ignore-compile: true`, and you run the install + hardhat manually before calling `slither-action` it might work. I haven't tested yet, but following something like...

Now that we are going to have multiple levels of info, it would make sense to move `compilationUnit`, `sourceUnit`, `contract` (could be renamed to `contractUnit`) into a subfolder? Maybe `unit`...

Hi @palmerss. Thanks, this is (again) a great idea. We will investigate how to implement it

We can switch to individual version for the detectors, but the AST parsing actually use all the versions, so we won't be able to save time there.