Juozas V.

@sajarin the PR is ready to merge.

``` 2022-09-13T15:44:55.3993207Z > Task :airbyte-integrations:connectors:source-amazon-ads:sourceAcceptanceTest 2022-09-13T15:44:55.3993803Z WARNING: Error loading config file: .dockercfg: $HOME is not defined 2022-09-13T15:44:55.3995006Z ============================= test session starts ============================== 2022-09-13T15:44:55.3996134Z platform linux -- Python 3.9.11, pytest-6.2.5, py-1.11.0,...

> @sagew4 @monai I was running the tests locally using the same credentials and the CI and the tests were hanging. It's possible there's an issue with our current config...

Hey! I'm participating in the Airbyte Maintainers Program and am assigned to review your PR. The PR is straightforward, and the code works as expected, but I'll ask you to...

You reverted commit that changes `additionalProperties` from `false` to `true` in 9c4e5672c23f8ad76dc1ada092f654fac2ba8c8d. But now acceptance tests fail again. Instead, remove these properties from `VendorDirectFulfillmentShipping.json`. `additionalProperties` default value is `true`, so...

Yes, it should. Without fixing the `VendorDirectFulfillmentShipping.json` acceptance tests fail. Unless the tests pass, the PR cannot be merged. You already had fixed it in 84470469d6dbba3466cde5eab9471cb03e7d1f78 and then reverted in...

Well done! The PR now looks great and is ready for merge. However, the `NonBackwardCompatibleError` error is new to me. It seems that this is a regression introduced in #15520....

I can confirm test passing. So, the PR is ready for merge. cc @sajarin

Could you please refactor the spec input type to enum? See https://github.com/airbytehq/airbyte/pull/18677#discussion_r1021689703

Looks good. I'm going to proceed with publishing the connector. ~~Please do not push anything to this branch anymore. Doing so in the middle of publishing might break the process.~~