Molly Rose
Molly Rose
I'm hoping to have some time to get to it towards the second half of this month. Maybe targeting 2.5 makes more sense?
Hi @gi0baro, I've got some time and I'm taking a look at this this week! I noticed that the call to [`Path::canonicalize`](https://doc.rust-lang.org/std/path/struct.Path.html#method.canonicalize) in `match_static_file` may block to resolve symlinks: https://github.com/emmett-framework/granian/blob/0324e6c9a4e8f275a61ed383bfd1f321817a83d1/src/files.rs#L21...
Agreed, I wouldn't want a stray symlink to potentially expose content outside of the mount point. My concern was that `Path::canonicalize` would block the worker thread while it was checking...
PR is up: #646 I created a new issue, #647 to track investigating `Path::canonicalize`