Molly Weitzel

Now there are issues again 😫 Looking into the failures now...

> Now there are issues again 😫 Looking into the failures now... Okay scratch that. I've re-run the integration tests in CI 5 times in a row and they've passed...

> > Now there are issues again 😫 Looking into the failures now... > > Okay scratch that. I've re-run the integration tests in CI 5 times in a row...

Based on comparing the logs of a successful run : (see [here](https://s3.amazonaws.com/buildkiteartifacts.com/ce5a7366-33fc-414f-aff4-ac5542f2233f/1c544f6a-e12e-42d5-bfff-b3c95f10496d/018292e3-179d-49d1-b76e-3006a05d7897/018292e4-279e-4261-b5f6-4059e48c52dd/server.log?response-content-type=text%2Fplain&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7LVFXRWW4H%2F20220812%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20220812T164658Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEBAaCXVzLWVhc3QtMSJHMEUCIGwxE%2F1fiiRBuz%2BI%2Fy%2BI%2BdGufY4HpdY6tmJmma8JQbl2AiEA6GeX%2FFDjW1V7%2FVYK9FvvUc9fIhqLxw1tNp8nSYLG0aMq0wQIeRAAGgwwMzIzNzk3MDUzMDMiDDRgRKT6fQxjMuBgYSqwBGuTPrQvD4azk2s%2FoZgnSfbB%2BPC871%2F1bGuo7PSjWlWOwpqvpZ0BjP2fyDp41u3sq1Fag0LGAkxfHtiWoxBo4xz7gCBz9%2FYQszm8nUQP6SgRU2b0m5mwU9zQu6PgFLgB0s51CL1WdqlOWHYtsYq5DKzkAd49dGuQlHSk00aHEZGm3rC2X833CBQWihcl8%2BkleoiM14253mfcnoumYG0vBSrUgVpdDTwMiokOEcsRIo664TPmVb%2BUXO2TpxGgafGl1%2F4CU8Ingze5JSGRhphVSliwGNRIXNc6njo9q3%2BK6vh%2B8ZWDLBLxUvACQSTaWaB21X3cYrrQiTzhf9oOttu%2FnNZ3Y46lK4TCUzgPaUrC3PWx%2FJHe70anA5YmTXBaKeSrFLaz%2Bi9r51DTPXdNZB9D0lBaZD44blDyMZh8th4kD2rVQ2ma5TC%2Bv6GFxavavZRIOqBLtfbRVOPJtxER%2FEUDwu2UkKLAtysFoPOtW%2FrdalRxvZZ%2B2D5hLZ%2BUAc6SU1vJ9QtUPoj%2BMW3RpXYUSUKmgOK81s7K1iRSNxaWfti73UfVDiwXH4wQAIFZihepQvhf%2B3yfgALTs4FPcPDednx65%2FvFqu35gCS4%2BELtchxrDg9tuHA1Qqv18jZ5GJi3gKIrdx1oh5LtnPnXKH4dck1YDYsVWH3SRyg%2FsnYfpQCQM5YcuI9qfR7BegnvWy4QL8LVu%2BJ1biQBNZRA0Sxh2FQUqbxiXyfJnBcNQe%2F7ZV4g31wEML3u2ZcGOqkBrtQIjXlWxjiRrNbkNg4NMLtdSgWkxPChrmchW7iFtA5fb45be97cy%2BtNgmQUrgIEAvVN7vEFoTF2Kcws%2FesF2uloq2%2FqqvwkzLejY8IWMeWpil2FQhbC0P3FQBQsnf8HO3QsxliHSS%2FYG0qGCGkltohoa4RZslpiBajo5%2Ft11yYgXoU4qFGtEylEub9j2OhxehPvPRvYEumMOHqg0TWbdVP17z2XIVf%2FSg%3D%3D&X-Amz-SignedHeaders=host&X-Amz-Signature=a1f3723eb6b50a5fe6c9cc9f1b04f5c5307decd9f3db9d665b5f31bb33cd996e) ) vs an unsuccessful run (see [here](https://s3.amazonaws.com/buildkiteartifacts.com/ce5a7366-33fc-414f-aff4-ac5542f2233f/1c544f6a-e12e-42d5-bfff-b3c95f10496d/018292af-20aa-42ca-b368-9962f843e309/018292b0-0a78-4c4b-9d3d-ef558829ca95/server.log?response-content-type=text%2Fplain&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=ASIAQPCP3C7L6KO27LZU%2F20220812%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20220812T154709Z&X-Amz-Expires=600&X-Amz-Security-Token=IQoJb3JpZ2luX2VjEA4aCXVzLWVhc3QtMSJGMEQCIHDxJ60OsTaedqhRZ6F0Uvg8bjR3%2FyKRM%2BHXSNBNN5W%2FAiACjlLKMunFMPbqYA1fuOWqnBhJUc%2FF0FLZvF0UquL%2BKirSBAh2EAAaDDAzMjM3OTcwNTMwMyIMeG7r%2FtphDjx1EjbYKq8Ebr0r1XakQKJ9GAKUK3kpF4V7%2BQjtKOe0fxkrFJ%2FNJK2ERJwnACpmG4%2FgI0%2BLNNgNQ45TG8SwQq1kEEo3yHfHeSpIF6bXfc4bDC9O8IXS7%2FDK1X2bJdVPHaWZTBYQ3zOKEs7UJegQbuoGKsc65rM4NqbKwmd%2F0NtA1uQ6P2b7rOu9H33rI014LxOIfjtXGAL0rGq4nVqcEI6%2B3Am8nF4%2BTpuMbcNll%2B%2FlhQqde6HzhiB00xanRrt2vLOdH9PC4YNHE3xWGzBgf8ZyPYm48th8fv1vjUlkKQu7Dzf7q1%2FXepvHMB0GVegAdw%2FilbRxEORlj5MOXQ2kx9YuqCvWlJiUgEuCrVoxpCA58sQoSgom2CWCdYD4nTAKV%2B3frJRmJAHXxjh72qW%2BQi2gEERwt8cmN%2BqWR60YlOr8TH9Vnv6QcTdaqsQ7V%2BODpMLvAEtvu4FLxY%2FeVybKX1xdl818zFKc%2FSaRSGNHG74QCcF%2BzlhXWdn3aSiigX9Wjgnk6WVlLdbVu2t21MMqn6MelT5aNypY71%2BHmXcvq6k%2FjeEcVupikhbudh87TXU6w1xkP5QQZvc4VbN6PR9D7J1HkcOI6S042noI%2FjxBAPNsbCt0tWbamJKozwbnkzf748%2FzCV06QxMkUgleF%2BuQ3N%2B0jJ3oe%2FBtWA8%2Fmlrz59hA6NivD2%2BkvfQo6ULa%2Ba6U3W4qiLPaBzmTxjaLTZ69tpRo0YMAlmupUAsy0BhFJjMjHJss6kG75zD4oNmXBjqqAd8AjThoccbdMluNa83eWhA5SYkUdCEZvQwNuZB6hm8c6O2aQbZjRkUYvcRfik6jpFMKfylBpgeP6e4CUiUmdd99%2BTh%2F%2Bir9bJLwMqeP%2F%2BQpy8BwFqPWtLdwwNAPmvjae4xCLiBbBQSAapQgkl9DOmMlfDuStmBVS8hGNSFj%2B%2BdKKWlAXGQzpEs%2FQOY6%2B469xv8iZ7i%2FO64FaUpuGsSnHpQTvf0saq41WvRj&X-Amz-SignedHeaders=host&X-Amz-Signature=ee1c681b3ab3047262e08fecc541fd840879bbf844153fe33d788a7a7dc50072) ) it looks like we never make it to calling `fetchUserPermsViaExternalAccounts`...

> > This could be fixed in the test by manually syncing `alice` 's permissions before running the test cases, but that still doesn't explain why `alice` ever has access...

Looks to me like [this](https://sourcegraph.com/github.com/sourcegraph/sourcegraph/-/blob/internal/authz/sub_repo_perms.go?L204-211) may be the culprit. We're making it here in the test _before_ the sub repo perms are synced.

I've run the tests 10 times for the most recent commit and 20 for the one before and so far the integration tests are all green. This can probably get...