Mattias Michaux

Results 52 comments of Mattias Michaux

@escopecz I would definitely not re-implement a deprecated method and token. Using the Symfony standard looks best: `%kernel.project_dir%` and `getProjectDir()` and hard-coded `app` dir This change has obviously impact, as...

@dakur There are other places in the codebase that depend on `sys_get_temp_dir()` directly (which makes sense), so adding an extra param to `FilesystemTagAwareAdapter` wouldn't solve this fully. It looks like...

@RCheesley thanks for starting the pipelines, this will already give more info about the next issues to tackle. I'll also update the description of this PR once it is more...

@mautic/core-team could someone approve and run the tests?

@RCheesley it looks like @ mautic/core-team doesn't exist (anymore), who do I ping in the future?

@RCheesley I did the comment before I pinged you, but it doesn't appear as link, so I assumed something was wrong :)

@RCheesley could you start the testsuite please? thanks!

@escopecz do you know why the testbot is not picking up checks? Can we force this somehow?

@escopecz looks good and indeed needed fix! * correct branch is pulled * commit corresponds with the latest commit from https://github.com/mautic/FOSOAuthServerBundle/commit/33bc2f43bcd100d00afd03d39c05bdebd14467ca

@saschafoerster can you specify what files are missing? As the original issues was for M4, not M5, and I haven't experienced missing files in composer based M5 installs.