Mo Langning
Mo Langning
Was this from milw0rm (the site)?
#939 Is a improvement of the checker scripts but it hasn’t merged yet. Can I commit that fix instead?
I’m still fixing it, would this suffice? ``` for line in contents.splitlines(): line=line.strip() ```
The purpose of the checker was to detect empty lines and new lines at the end of the files.
There is a possible case where instead of an empty line there is a line with just whitespace. ``` [“hello”, “ “, “”] ``` the second element should be flagged...
I agree with you, and so that’s why it outputs a warning and not an error. It’s not a requirement but if there isn’t supposed to be a empty line...
I added some more changes https://github.com/danielmiessler/SecLists/blob/46b13d564819db3aa2b2c59998150a9c1a05f564/.bin/checkers/new-line-and-empty-line-checker.py#L54-L65
Good catch! LGTM
A commit script might be helpful as we are just copy and pasting commit codes
I made a commit script, you can check it out here https://github.com/molangning/irr-tracker/blob/main/run.sh https://github.com/molangning/irr-tracker/blob/main/.github/workflows/update.yml