SecLists icon indicating copy to clipboard operation
SecLists copied to clipboard

fix(CICD): Corrected multiple issues in GitHub Actions workflows

Open ItsIgnacioPortal opened this issue 2 years ago • 4 comments

This pull request fixes the following bugs 🐛 in the Seclists Github Actions:

  • Some wordlists were executing on every single commit instead of only executing when one of the specified paths were modified.
  • The Wordlist Updater - directories GitHub Action had an incorrect job name.
  • The Wordlist Updater - directories GitHub Action had trailing whitespaces in the trigger filepaths.
  • The workflows Wordlist Updater - Trickest wordlists updater and Readme updater - Updates readme with latest stats had missing content: write permissions, which caused these actions to fail when executed in a Seclists fork with the default github-actions account security settings.
  • The workflows Wordlist Updater - directories and Wordlist Updater - words had hard-coded repo URLs, which caused the workflow runs to fail whenever they were executed in a fork of Seclists.

ItsIgnacioPortal avatar Apr 25 '24 02:04 ItsIgnacioPortal

Good catch! LGTM

molangning avatar Apr 25 '24 03:04 molangning

Added:

  • I've replaced the email address [email protected] with the email address of the official github-actions bot. Fixes: #1023

ItsIgnacioPortal avatar May 10 '24 05:05 ItsIgnacioPortal

A commit script might be helpful as we are just copy and pasting commit codes

molangning avatar May 10 '24 05:05 molangning

I made a commit script, you can check it out here https://github.com/molangning/irr-tracker/blob/main/run.sh https://github.com/molangning/irr-tracker/blob/main/.github/workflows/update.yml

molangning avatar May 10 '24 06:05 molangning

Hi @ItsIgnacioPortal - Oh super wowerz!

Unfortunately before this can be merged in, could you fix the conflicts?

g0tmi1k avatar Jun 11 '24 15:06 g0tmi1k

Hi @ItsIgnacioPortal - Oh super wowerz!

Unfortunately before this can be merged in, could you fix the conflicts?

Conflict fixed 😃

ItsIgnacioPortal avatar Jun 13 '24 06:06 ItsIgnacioPortal

Thanks a lot for this @ItsIgnacioPortal! (Really!)

Merged <3

g0tmi1k avatar Jun 13 '24 08:06 g0tmi1k