Moritz Klack comments

Results 440 comments of


                                            Moritz Klack

trafficstars

[BUG] Invalid assignment / no type checking between the data field of Node<NodeData> types

In v12 the `Node` type has new generic specs: ```js type Node = < NodeData extends Record = Record, NodeType extends string | undefined = string | undefined>{ ... }...

Add `deselectOnSelection` prop for configuring if starting a box selection clears selected elements

Interesting! I just tried Figma and Blender and both are not deselecting when you start a selection box. And I agree that it would be helpful to change that so...

Add `deselectOnSelection` prop for configuring if starting a box selection clears selected elements

Do we need a prop for this like `deselectOnSelection` or something like that?

Add onBeforeDelete handler to control deletions

@jt6677 that would be possible!

macOS trackpad pinch zoom on Safari is not working

Thanks for the fast reply! I'm not sure if I can help here but I'll look into it.

Unmet peer dependency yo@>=1.0.0

Thanks I will check that!

Render loop after v11.10.3 to v11.10.4

in v11.10.4 we fixed an issue with unsynced states between user and react flow. It seems that it causes an issue in your case. I will also investigate. Let us...

Render loop after v11.10.3 to v11.10.4

Are you working with a custom `applyNodeChanges` function? Could you provide an example @noams-unbiased ?

Render loop after v11.10.3 to v11.10.4

Are you working with an uncontrolled flow or did you remove the other parts of the `onNodesChange` function? Which React version and which browser are you using?

Render loop after v11.10.3 to v11.10.4

The issue is that you are not adding `width` and `height` to your nodes which means that they are not initialized for React Flow. In the previous version this worked...