Moh Osman

Results 8 comments of Moh Osman

> linting failed I think that was because I had some spaces instead of tabs in the webhook file. `golangci-lint run` is not throwing errors for me locally anymore. Can...

> @moh-osman3 CI failed @pavolloffay Sorry for delay I was on PTO last week! Yeah I noticed CI was failing due to unit test error ``` --- FAIL: TestHPA (0.00s)...

@pavolloffay The purpose of adding `TargetCPUUtilization` to the CRD is because we wish to tune this value and provide a recommended setting to users. Previously with `90%` we are experiencing...

Hey @dmitryax @timannguyen thanks for all your work to create this `memorylimiterextension` and to make it useable by receivers. I just wanted to check in and see if there's anything...

>> I tried to prototype this approach in https://github.com/open-telemetry/opentelemetry-collector/pull/9590, and it seems like it doesn't work with having memory_limiter option right in httpconfig and grpcconfig configs. @dmitryax Hmm I've checked...

>> I think users should be good just with using GOMEMLIMIT instead @dmitryax Can you expand on what you mean here? Are you saying that GOMEMLIMIT should replace the global...

@dmitryax I'm still wondering if we can have multiple modes of memorylimiting. 1. The existing one based on polling the runtime statistics to see if we are above the configured...

Resolved by https://github.com/open-telemetry/opentelemetry-operator/pull/1066