Results 228 comments of Brian

By the way, I've been thinking about my proposal for ':='... I think you can actually get away with just '=' but you need a very very robust heuristic to...

Rejigged the syntax and looks like I'm now settling down to this syntax: ``` a = 5 b = 7 c = a + b = 12 = 12 1...

Actually @josh-ramer when I ran `./scripts/debug-test.sh test 24` with this script I noticed this printout ``` Ran Test #24: test-eval-callback GDB args: /home/mofosyne/gitextern/llama.cpp/build-ci-debug/bin/eval-callback "--hf-repo" "ggml-org/models" "--hf-file" "tinyllamas/stories260K.gguf" "--model" "stories260K.gguf" "--prompt"...

Maybe you can suggest a better comment? Either way, see if this script is working well for your flow and if I didn't break your gdb flow, then well should...

@josh-ramer see if you can press approve as there needs to be one other approval before it can merge in.

Not deeply analysing the changes but these are the general observation if it would help other reviewers: * Commented out #define removed * Extracted 5 duplicated lines into `ggml_vec_soft_max_f32()` *...

Does makefile have any method of switching on/off certain logging? E.g. debug/info/warn and per subsystem Might address what he was thinking here --- Setting to draft for now, as we...

Doesn't appear to be enough consensus for this to be included, but thanks for your contribution! Closing for now.