Callum Moffat

Results 83 comments of Callum Moffat

I tried it out in my app, works well :thumbsup: FYI Pan/zoom = trackpad scrolling event. Zoom/scale is not relevant here, only pan, which could also be called scroll. When...

@xiaoyanermiemie I think I wasn't clear. There isn't any problem with your PR when using trackpad and touchscreen at the same time. It's all good :thumbsup:. I mean that when...

@xiaoyanermiemie I mean other apps which don't use Flutter at all. When I said other platforms, I meant UIKit, SwiftUI, Windows UWP. See what it looks like using touchscreen and...

I agree. It would make it better to deal with iPhone notch as well. The additional padding would be at image painting step, rather than around the image widget.

@zmtzawqlp When you have that approach, the border is outside of the zooming image widget, so you always have a border around all sides. See my approach in #509 to...

> @moffatman thanks for the contribution, looks like there's still a few minor updates needed (mostly comments and clarifications) to get this through. Yep, will be addressing it soon. I...

@hellohuanlin I updated the numbers after some further data collection. I took the excel line-of-best-fit and subtracted an additional 200ms to account for all outlier data points (we want to...

@hellohuanlin The other PR is kind of related, they both need to estimate the macOS scrolling curve, and improve scroll experience on Mac. But they don't depend on each other...

I thought it wouldn't apply to all `GestureRecognizer` subclasses, since some have specific handling and separated callbacks for different buttons already. And it looks like the single-drag recognizers that are...

I solved it by adding `com.google.iid` and `com.google.iid.checkin` to the keychain sharing groups