ThemePackagerComponent icon indicating copy to clipboard operation
ThemePackagerComponent copied to clipboard

ThemeForest one folder requirement

Open DESIGNfromWITHIN opened this issue 10 years ago • 1 comments

A ThemeForest MODX theme needs to follow this rule now:

Themeforest submition: Theme must include all assets needed to generate the site, inside the assets/ folder

This means I will need to place lexicons and docs in my assets folder as well... Not really the 'MODX way'. It works for me as long as I use the following namespace settings:

namespace: ivory
Core Path: {assets_path}templates/ivory/components/
Assets Path: {assets_path}templates/ivory/

My files are now like this:

/assets/templates/ivory/
..... all normal assets theme files
/assets/templates/ivory/components/
/assets/templates/ivory/components/docs/
..... theme docs
/assets/templates/ivory/components/lexicon/
..... theme lexicons

We might need to address this to prevent future confusion, components files should not be in assets!

DESIGNfromWITHIN avatar Apr 10 '14 11:04 DESIGNfromWITHIN

If it's only lexicons and docs that are in assets that doesn't really matter much to be honest and your solution is great. The main reason I can think of for separating executable files into a core folder and an assets folder for the rest is security (when the core folder is moved out of the webroot, and even that's debatable as most files cannot be invoked directly), and I'd be seriously impressed if someone finds a way to exploit a lexicon file.

Mark-H avatar Apr 10 '14 12:04 Mark-H