modmuss

Results 504 comments of modmuss

Hi, thanks for the PR. Unfortunately I dont think this is something that fits within the scope of what we want in Fabric API. We already have the events, so...

What minecraft version and launcher are you using?

Seems to be crashing when running: ``` Caused by: java.lang.AssertionError: Expected field ConventionalBiomeTags.IS_VEGETATION_SPARSE_NETHER to match one of [IS_SPARSE_VEGETATION_NETHER, NETHER_IS_SPARSE_VEGETATION] for tag TagKey[minecraft:worldgen/biome / c:is_sparse_vegetation/nether] ```

> in discord what to do about the naming of the biome fields but got no feed Ah sorry, I am just catching up on things now. `IS_VEGETATION_SPARSE_NETHER` seems fine...

> I won’t be able to do the new wood stuff because that requires special handling with feature flags that’s outside my skill set I can maybe help with this,...

I would strongly suggest getting this PR updated to 1.21.4, let me know if you need help with that. Back porting the tag aliases is not trivial.

> #4186 Ah! my bad, I got confused by there being 2 PRs with the same name. Ill take a look at it shortly, we can get that in ASAP...

Thanks for the bug report, I have reverted the change that cuased this, 0.114.2 is releasing now to fix this.

Hi, sorry for not taking a look at this PR in a while, please don't heasiate to ask me to look at PRs its impossible for me to check them...

> An alternative could be that we enable more things by default, this is gonna be a bit subjective, so it would require some conversations to see what exactly people...