modmuss
modmuss
Please keep this discussion on topic, this is about what we are doing for Fabric. 👍
Changing now is going to be a right pita, you have given a good reason to do it the current way. It’s a minor detail as well
Im happy to do this for 1.16 TR, will need to write a script to make the changes.
It looks like the conditionalrecipes game tests are failing. 🤔
I think this is fine, I havent looked at it in depth, but the idea seems solid. I think we discussed this before, but are we happy to have this...
I have added 3 blank test mods, hopefully this will help you make some tests out of them. I also made some small code cleanup/changes with unit testing in mind,...
> I've tried getting the testmod to load but it crashes with `NullPointerException: Cannot invoke "java.util.jar.Manifest.getMainAttributes()" because "manifest" is null` :P Sorry I missed this. Where are you seeing this...
This was fixed as part of: https://github.com/FabricMC/fabric/pull/3832/files It likely need backporting to 1.20.4. Disabling assertions is a workaround, this will only affect development environments.
Id add this to the existing ScreenEvents class as `OPEN`
> > Im not sure about this, as the existing screen before/after init events provide a lot. As far as I can tell out of your use cases the only...