that-depends icon indicating copy to clipboard operation
that-depends copied to clipboard

List of possible features to implement

Open lesnik512 opened this issue 11 months ago • 3 comments

https://github.com/ets-labs/python-dependency-injector/pull/765

lesnik512 avatar Mar 21 '24 18:03 lesnik512

Can those features be implemented in a way that wouldn't break type checking and require typing.cast() usage?

vrslev avatar May 16 '24 20:05 vrslev

I think so. Good type checking is one of the basic ideas of this package. I'm not sure, that we need all these features. It's just some ideas for the future.

For example, I don't like configuration provider and thinking about injecting whole settings object or separating it into smaller singletons instead of configuration provider

lesnik512 avatar May 17 '24 09:05 lesnik512

  1. Injecting a factory–I use that a lot. I like the way pdi fills in args for you when it gives you a Factory in a caller.
  2. The way pdi does configuration isn't great. I use pydantic-settings v2 and to get it into a Configuration object in pdi I had to hack it + you lose type safety. Seems hard but would be so great to solve!
  3. I use Selector a lot, it's a great feature.

I'm stoked to see this project coming along! If any of these sound like good starter tasks I'd be interested in trying one out. I'm using pdi in production at my job and need a path forward!

jasonprado avatar Jun 06 '24 20:06 jasonprado

Thank you, Jason! Great to hear, that this project can became useful not only for my projects.

I will split this issue into parts and will write ideas, how they can be implemented, so anyone can contribute.

lesnik512 avatar Jun 07 '24 06:06 lesnik512