Robert Fletcher

Results 145 comments of Robert Fletcher

See https://github.com/rmagick/rmagick/pull/304 for the latest PR.

@jdelStrother if you want to have a go at it I think we'd be open to it. As @Watson1978 mentioned we might need to deprecate the monitor feature first, which...

@Watson1978 @dlemstra It would be good to get your feedback on this PR. `Image#chromaticity` has some confusing behavior.

FWIW, we disable it for performance reasons. Validating the record can cause extra db queries if the association isn't already loaded. This is especially a problem when validating a number...

> Wondering why does Rails fetch the whole record `SELECT * FROM ... WHERE id = ?` when a `SELECT COUNT(id) FROM ... WHERE id = ?` would suffice to...

@avk unfortunately, that's not the issue for us. Production is fine, it's just when deploying, any time we make changes in development, and running our CI build.

Yeah, we've got browserify-incremental enabled. We still do have a lot of sprockets requires, though, so I figure once we get those sorted out it will hopefully improve. Still, it...

Still having pretty bad performance issues even after we've converted all of our code to use node-style requires. One thing I see is that there are a lot of "Browserify:...

I think I might give [webpack-rails](https://github.com/mipearson/webpack-rails) a try, but I'd prefer a solution that integrates smoothly with the asset pipeline, at least insofar as Rails supports it. Sprockets has always...

We're using the default settings, which I think uses browserify-incremental, doesn't it? At least, we're not doing anything to disable it... I'm going to have to educate myself a little...