Gregg Reynolds

Results 46 comments of Gregg Reynolds

Thanks! So for SortableBlacklist I would add something like "ocaml_library.deps: true ? On Fri, Jul 17, 2020 at 5:26 AM Vladimir Moskva wrote: > You can mark a certain list...

Let's hold off for now. The comment works, the ocaml rules are still under development. Thanks Gregg On Mon, Jul 20, 2020 at 10:51 AM Vladimir Moskva wrote: > Yes....

> Yes, the `.cmx` is used during compilation to perform inlining. Are you sure about that? I would expect such optimizations to occur only at link time. If they're done...

"The type of the functor parameter ... has more requirements..." Types do not have requirements. Even if you construe the fields of a sig as requirements, there are two ways...

> Would it work to remove the directory part from the install name (ie have the install name be only `libasmrun_shared.so`)? Nope, tried that. I also fiddled around with `@executable_path`,...

> It looks like the proper fix would be for the Makefile to call `install_name_tool` after installing the files. That's what it looks like to me too. The DSOs in...

Strong recommendation: always use `BUILD.bazel`, not plain `BUILD` - avoid any possible name clash with other tools. Ditto for `WORKSPACE.bazel` (althought that file will be going way with 7.0)

Second strong recommendation: you might as well start with Bazel modules. It's vastly superior to WORKSPACE-based dependency management. See my [fork](https://github.com/obazl/binaryen ) for an example.

Recommendation: follow Bazel best practices; in particular, avoid toplevel build targets like `bazel build :foo`. Also prefer one BUILD.bazel file per source directory. Better to avoid having file paths like...

Just for fun I wrote a very simple C program that generates `src/passes/WasmIntrinsics.cpp` directly from `src/passes/wasm-intrinsics.wat`. No need for a template file, and this also eliminates the need to pull...