Mike Nichols

sed on OSX

1

Great series! On OSX the `-i` flag for `sed` requires a value so I changed this https://github.com/jonbcampos/kubernetes-series/blob/master/partone/scripts/deploy.sh#L15 to `sed -i '' "s/PROJECT_NAME/${GCLOUD_PROJECT}/g" ../k8s/deployment.yaml` Thanks for sharing your knowledge!

Multifile compilation support and tinier output with --js option

3

Hi this patch does the following: UPDATE : I just added namespacing for templates, based on the directory structure. So you can have this structure: - templates myTempl.coffee => this.templates["myTempl"]...

Empty OK reply gets dropped

3

When redis replies with a reply meaning no records are found it is `+OK/r/n*0`. The `replyParser` function returns `fn()` as a result making the pipe stop altogether (filter). It seems...

Hi This pull request changes behavior of the replyParser to support multibulk replies as empty lists (per redis docs). It also allows passing an array of args into .write(...) instead...

RunID is needed oftimes when relying on HasWorkflowSerializationContext in a PayloadCodec or Converter

3

**Is your feature request related to a problem? Please describe.** RunId is not included in `HasWorkflowSerializationContext`. This makes it hard for PayloadCodec implementations that are caching payloads to disambiguate execution...

I was trying to figure out the best way to test cancellations of Child Workflows. In the past, only cancelling the context was possible so I thought I'd try out...

[Bug] TaskQueue not forwarded when using Test Environment, breaks ContinueAsNew (hangs)

1

This test hangs because of a grpc reported missing TaskQueue (see below for error message): ``` using Temporalio.Client; using Temporalio.Exceptions; using Temporalio.Testing; using Temporalio.Worker; using Temporalio.Worker.Interceptors; using Temporalio.Workflows; using Xunit.Abstractions;...

[Bug] TimeSkipping test server hangs when testing Update

1

### What are you really trying to do? I was trying to test `WorkflowUpdate` in my own code and was using `StartTimeSkippingAsync` . My test was hanging each time even...

When an activity implementation has some call that might "hang" or take a very long time to complete, we want to be able to cancel that due to a `ActivityCompletionException`...