Matija Nalis

Results 924 comments of Matija Nalis

I think this PR would benefit from outlying in more details exactly ***why*** is it doing changes (i.e. what exactly new user-requested functionality will become available), instead of just enumerating...

**TL;DR:** great for adding support for adding/changing (optional) tags on notes, as well as (optional) extra API params / website changes to filter by them; but please no mutable note...

> amenity=bicycle_repair_station; service:bicycle:pump=yes That part sounds good to me. > I would also suggest adding service:bicycle:tools=no to indicate that this is only a pump and no tools are present, since...

Perhaps it is related to sharing a contact (via `.vcf`) file? But it doesn't work for me on Android 14 (shares zero-length file anyway) **Edit:** also, see https://github.com/marcosdiez/shareviahttp/issues/48

> Icons will lose information unless you color them. They would; but that is why _**colored**_ icon was requested: > [....] by the real **but coloured** icon of each thing...

Also, probably device dependent. On my Samsung Galaxy S23+ (Android 14), it does not seem to be affected: ![Image](https://github.com/user-attachments/assets/ae005338-2410-4469-a508-e37830aedcda) (areas shown due to _"Show layout bounds"_ in _"Developer options"_)

Yeah, few presented choices are similar/confusing... I'd go with cleanup there of that few circled values there, but remain with small fixed palette using mostly (and preferably _only_, if possible)...

> would you be open to adding a feature that returns the color name when your app is called? Before people invest effort, I should warn that I'm heavily against...

> So why is it so important to distinguish one shade of color from the probably 43493 very similar other shades of the same color? Yes, it is impossible, so...

As an experiment, I took few pictures with 4 different phones, one after the other (i.e. same time of day and same color temperature -- which is likely to be...