Marija Najdova
Marija Najdova
@schopra8 you can override it by adding the touch ripple classes, here is a short demo: https://codesandbox.io/s/affectionate-jerry-7uqf81?file=/src/App.tsx You can check the [TouchRipple.js](https://github.com/mui/material-ui/blob/master/packages/mui-material/src/ButtonBase/TouchRipple.js) source for more info/inspiration.
Interesting, so far we only see the need of applying integers there. Have you thought of maybe adding additional tokens in the theme that can basically contain these values, like:...
> I don't feel like this is efficient. Having to add more imports for constants sounds like bad practice. Having a place to define tokens and then use them as...
> I noticed that in the button, we have the same class twice, I guess it comes from both the ButtonBase and the Button component. image I propose we leave...
@michaldudak can you prepare a codesandbox to show that this works? I tried the package from the latest commit in https://codesandbox.io/s/naughty-haibt-jr5gq3?file=/package.json (see https://jr5gq3.csb.app/iframe.html), but the issue is the same.
I like this, it's much easier to reason about 👍 The components that would use the unstyled can add the `component prop and the forwarded props if needed. Off-topic, should...
Just clarifying that I understand the proposal correctly. We would have `slots` and `slotsProps` in Mui Base, Material UI and Joy UI, that would behave the same (replace completely the...
> I'd say that I expect big change for Material UI because most components are using another pattern. e.g. Accordion has TransitionComponent and TransitionProps. This will be breaking changes: >...
> whereas the slots prop would replace the whole slot (unless it has a different behavior in styled vs unstyled libraries). Yep, component props is "as" and the slot props...
> It comes from a https://github.com/mui/material-ui/issues/27651#issuecomment-1123258293. I was missing this in the PR description.