Marija Najdova

Results 223 comments of Marija Najdova

We had only one issue around this in MUI so far. We can wait to see if more pops up. I can link them here.

> @mnajdova unsure how feasible that would be but allow this to "fold" could be a potential performance improvement (the React tree would get flattened/smaller). This is a tradeoff we...

Same issue is surfacing when using mui v5 with styled-components. I am not sure if it is also related to it being an external dependency (there is another issue around...

You probably should use `topLevelImportsPath` to import `styled()` from different location. Based on the tests this is supported, see https://github.com/styled-components/babel-plugin-styled-components/blob/main/test/fixtures/add-identifier-with-top-level-import-paths-and-named-import/.babelrc and https://github.com/styled-components/babel-plugin-styled-components/blob/main/test/fixtures/add-identifier-with-top-level-import-paths/.babelrc Should be confirmed by some of the maintainers.

It's similar to issue that we have at MUI - https://github.com/mui-org/material-ui/issues/29742

I wouldn't change how it behaves, mainly because we want the buttons to have consistent height. If you disable the ripple, you would probably want to add some focus indicator...

Yep exactly, sorry for the late response :) Should we close the issue?

Great execution @ZeeshanTamboli and sorry for the delay with the review

The Typography now supports the system props (color included), so you can do this: ```jsx MUI example. Please put the code to reproduce the issue in src/Demo.tsx ``` Here is...

> I don't think that we need our permission. However, for a recommendation, I think that https://github.com/vercel/next.js/tree/canary/examples/with-material-ui's pattern would be better, to avoid the dilution of the effort. Agree, I...