Martin Angers

Results 89 comments of Martin Angers

@lukeheath The description says "from their SSO", but this is an endpoint authenticated with the Fleet Desktop device token, right? The same one that can access the `GET /api/_version_/fleet/device/{token}` endpoint...

@zhumo Allright, I think I understand with that clarification (thank you!), so to rephrase how I understand it: all the Fleet API would be only allowed behind their SSO (so...

Hello Nathan, Thanks for looking into this. Makes sense that this is at the html parser level, would be nice if it provided the option to set javascript on or...

Hello, Good catch, looks like indeed the comments are not escaped when rendered (though I'm not 100% sure if it is a bug or working as intended per the html5...

I updated goquery's `go.mod` file to use the latest `x/net` dependency, but AFAIK it shouldn't matter - the `go.mod` that matters is the one of the `main` package, and its...

Closing now that the `x/net` issue is merged.

Hello, Thanks for raising this. It looks like you found an issue in Go's `x/net/html` package, here's a reproducible program that illustrates the issue with just the html parser: ```...

The `x/net` issue is now fixed and merged (https://github.com/golang/go/issues/37771), now working as expected, closing this.

Hello, It could be done, but there can be many valid selector strings for a given node, and there's no guarantee that this selector would be unique (that is, the...

Thanks for the context, yeah I see what you mean, I think it makes sense. I'm gonna try to give this a shot, maybe this weekend (no promises :). I'll...