Martin Angers

Results 89 comments of Martin Angers

@lukeheath @noahtalerman > For backwards compatibility, any query that points to any schedule or pack(s) maintains the team, interval, snapshot, removed, platform, shard, and version properties. These properties can be...

@lukeheath Something to keep in mind is the size of the response payload, but I think we're talking about a hundred or so policies at most so that should still...

@michalnicp > I don't think an API change was required here. We can differentiate between team and global policies using the team_id field. If it's null, then it's a global...

@noahtalerman @lukeheath I created this to track ongoing work required to keep #5222 validations up to date, feel free to close if you prefer a different tracking solution.

@noahtalerman Yes, that's because the automatically-generated part covered by 3) is just for CLI flags that can be used in the "options" key of the Agent Options (it's the "options"...

@noahtalerman It's a bit hard to discuss this without confusion with all the use of config/setting/option referring to different things :D But basically, under the `agent_options.config` key, we accept whatever...

> Ah, it looks like Fleet might support everything grimacing Yes, that's correct!

> can you please check to make sure I got the steps right? @noahtalerman yes, those steps look fine to me! > Is the validation going deep? As in it...

@noahtalerman gotcha. Currently, it does validate those keys so that means that for the next update, we must either: * Fail if the `agent_options.schedule` or `agent_options.packs` keys are present, or...

I update the ticket's description accordingly, and created #8066 to address the validation part (accept anything under those keys).