Michael Musenbrock

Results 18 comments of Michael Musenbrock

Could you give a hint for the code-format/formatter you are using? I tried to resemble the current style as much as possible.

> > Of course it is needed, so that the info is passed to the maven calls. But it may be more beautiful to append args in `executeMavenCommand` instead of...

> > ... But it may be more beautiful to append args in `executeMavenCommand` instead of manipulating the `argLine`. > > Have you tried that? @aleksandr-m I have created a...

@aleksandr-m this would be the [diff](https://github.com/redeamer/gitflow-maven-plugin/compare/feature/add_maven_ci_friendly_changelist_handling__via_argline_manipulation..feature/add_maven_ci_friendly_changelist_handling__via_mvn_execute) between those two versions (argLine-manipulation vs append mvn args)

> I tried to run first implementation and it always appended development changelist property for me. Maybe I need to configure something differently. Can you share configuration, goals needed to...

@aleksandr-m excpected result would be, that dependent on which branch is currently checked out by the plugin, the `changelist` property gets set to whatever configured via `productionChangelistValue`, `hotfixChangelistValue`, `releaseChangelistValue`, `developmentChangelistValue`,...

For example if I run `mvn -X gitflow:hotfix-finish -DhotfixVersion=1.23.1 -DinstallProject=true -DproductionChangelistValue='' -DhotfixChangelistValue='' -DdevelopmentChangelistValue='-SNAPSHOT' | grep DEBUG | grep -e "git checkout" -e mvn`, I see: > [DEBUG] git checkout hotfix/1.23.1...

@aleksandr-m I additionally updated the `README.md` to reflect the change. Please let me know if this is fine, or if you think more explanation is needed.

Hi @aleksandr-m, do you already have some input to share about this PR? Or is it still not behaving properly on your side and you need more information?

Hi @aleksandr-m, I prefer the property addition variant, so I decided to switch the content of the PR to that version. Both branches still exists in my repo for comparison...