pbrt-v3 icon indicating copy to clipboard operation
pbrt-v3 copied to clipboard

Sphere::Pdf does not return zero when wi points away from the sphere.

Open GaryHuan9 opened this issue 3 years ago • 0 comments

Thank you so much for the great book!

In chapter 14.2.2 Sampling Shapes, the second overload of Shape::Pdf returns 0 if wi does not intersect with the shape, which conceptually make sense. However, when Sphere::Pdf overrides this method, its implementation never returns 0 if the second (general sphere PDF) path is chosen, even if wi points away from the sphere. Is this a missed case in the code, or am I misunderstanding something here?

GaryHuan9 avatar Feb 03 '22 00:02 GaryHuan9