pbrt-v2 icon indicating copy to clipboard operation
pbrt-v2 copied to clipboard

Fix the bug about the direction of Normal.

Open nothinglo opened this issue 8 years ago • 2 comments

I have tested. It seems wrong direction of the triangle normal.

nothinglo avatar Apr 15 '16 13:04 nothinglo

If the order of those 3 vertices is counter-clockwise, then the normal is indeed v_12 x v_13.

DaviesX avatar Jun 11 '17 22:06 DaviesX

Changing this would end up flipping the normals of all triangles, which in turn would cause images to be quite different. Admittedly we haven't documented the expected vertex ordering, but given @DaviesX 's observation, I think that decreeing that they are counter-clockwise and leaving the code as is is the best thing at this point.

mmp avatar Dec 29 '18 21:12 mmp