Matt Pharr

Results 87 comments of Matt Pharr

Ack--sorry. I've reverted that, then. @webanck are those the only changes you need to build with gcc 7.3.0, or is it that plus `-fkeep-inline-functions`? Also, would you mind trying the...

I think this is the same bug as #343

Nice! Is there any chance of merging this, @lvandeve? I was about to prepare a PR to support UTF8 encoded filenames on Windows for similar reasons but was going to...

Fair point about the “decode from a buffer” option; that works for me as well. (And I share your surprise that plain old getting a FILE * for a file...

For q2: all textures in pbrt are defined with (0,0) at the lower-left corner. This is how it converts RGB to a tangent-space normal: ``` Vector3f ns(2 * normalMap.BilerpChannel(uv, 0,...

I think the issue is that the CMakeLists file assumes that WIN32 implies MSVC, for example here: https://github.com/mmp/pbrt-v3/blob/aaa552a4b9cbf9dccb71450f47b268e0ed6370e2/CMakeLists.txt#L359. It might suffice to changing that `WIN32` check to be for `MSVC`,...

Hm, that scene doesn't work with pbrt-v4 (or pbrt-v3 for that matter); The `Scale` is borked, there's no filename for the "plymesh", etc. I briefly looked at this and don't...

Good clue, though that turns out to actually be a red herring. (Basically, pbrt-v3's BSDF models were very much of the "add a bunch of lobes together until it looks...

No updates, unfortunately--I haven't had time to look at this in more depth. (Fixes welcome. :-) )

Strange! Can you try a debug build and see if it gives any more useful output? Also, a stack trace might be illuminating.