Mike Minns
Mike Minns
Thanks for the feedback, hopefully it feels like we're making progress :) I've been away but I'll pick it up again this week. 👍
Rebased after the latest changes to the Btbucket UI then I'll address the remaining comments 👍
Still a few comments to address 👍
Well that was a useful way to fill 2 hours of airport hell :) I believe I've addressed the key comments, let me know if there are any other issues....
Thanks for the quick response. My dogfooding will be a bit thinner than planned, I'm off with Covid for the next few days :(
Ah build failures. Everything tests OK on my mac and the error looks systematic, but I'm afraid I can't re-run CI checks.
I slightly cheated to re-trigger the CI, I rebased all of the commit messages to give them a meaningful first line. Fingers crossed CI completes this time :)
FYI I think there is a bug after all the refactoring. I'm just investigating
> FYI I think there is a bug after all the refactoring. > > I'm just investigating This should be fixed now, my dogfooding is working now.
WIP https://github.com/mminns/Git-Credential-Manager-Core/tree/issue/573-OAuth2-support-for-Bitbucket-DC