Mike Minns
Mike Minns
I'm actually having second thoughts about making _**interactive=never**_ and _**modalPrompt=false**_ do the same thing. Logically _**interactive=never**_ seems to imply _never ever show a prompt_ where as _**modalPrompt=false**_ implies _if_ you...
FWIW in the Bitbucket implementation we use OAuth to support 2FA. When the user makes a request to authorize via OAuth we open an external browser session and spin up...
I'm currently dogfooding this and awaiting some minor tweaks to the OAuth2 support in Bitbucket, once I'm happy it working and the OAuth2 support has been publicly released in Bitbucket...
I've been dogfooding this for a month and I believe its al working. Apologies for the size. A significant chunk is refactoring and tests. Thanks
Thanks for the feedback, I'll start taking a look this week 👍
Rebased first 👍
Also apologies for the surprising number of typos/comments/TODOs etc 😬
OK, I think I've addressed the issues mentioned above, I'm just working on restructuring the commits.
OK,I think I have a much better structure for the commits. I'm going to dogfood for a couple of days next week before pushing the rebase, fixes and revised commits....
I've updated the PR. I've covered the issues raised, hopefully. I've restructured the commits, hopefully this will make the review easier. But please flag anything you think still needs looking...