Mike M
Mike M
> If the aim of this is to prevent people from thinking that `ObjectsAreEqual` is an assertion that they should use, then I think this new `equal` package should be...
Yeah that's a good point. Tbh then I'm a bit reticent about introducing this change then, ~~as I don't want to remove useful functionality even if it is currently being...
I think I share some of @prochac 's concerns regarding context. Maybe I'm being a bit of a luddite, but recommending that the logger is passed around inside context rather...
Appreciate your explanation @v3n . I'm still having a slightly hard time understanding the benefit of the logger itself being passed around in context. I understand propagating the log correlation...
> It doesn't preclude dependency injection; if that works for you, stick with it. Yes, I understand that. I don't want to labour the point but my concern is that...
Just had a long discussion about this at work, and realised that this has caught quite a few of us out multiple times, so I'm in complete agreement that this...
Created a PR for this https://github.com/stretchr/testify/pull/1279
I don't agree, it seems to me like a standard approach to completely ignore the entire drupal project and symlink in custom modules/themes/config. At the moment there is a lot...
This is a big issue for me, +1
Could this be merged? This has proven to be a blocker for my use case