Michael Merickel comments

Results 366 comments of


                                            Michael Merickel

trouble using --aws-role-arn option when adding EKS cluster with argocd CLI

Just some quick notes on setting this up while sifting through a lot of confused comments above. - The role you create (roleA) doesn't need any permissions. It just needs...

Improve HoC connectToStores Docs

While the function itself is anonymous - now that `connectToStores` accepts actions I'd recommend renaming its usage in the docs to `connectToFlux` or something similar.

Adds Linkedin OAuth 2.0 provider

Can you please add tests/docs for this?

data['email'] raises KeyError with velruse.google.scope = 'opend profile'

whoops, if we're letting those be optional then I guess that'll have to be updated

Before and after login events

Great idea. I wouldn't subclass from NewRequest though. Is there a reason you did that? Events can be any `object`.

Before and after login events

The feature is good but I think instead of separate subclasses for each provider I will just use a subscriber predicate based on the name of the provider. I've been...

Error in OpenId connection

I added an OpenID test focused on myopenid.com. It's working so I'm not sure what your issue is. Maybe you can tell me what options you're trying to use with...

Standardize api for scopes

I think the supported options could be standardized but they'd have to remain strings because the scope can usually also be specified in the POST request to the login url...

create add_login_from_settings for openid providers

@2nd do you know if Yahoo's new auth machinery is bw-compat with existing applications? For example, if I create an application on Yahoo and use OpenID+OAuth, then we switch to...

Need to be able to store some context before sending to the provider

Velruse would probably store this information in the session. It tends to use the state parameter for CSRF checks to validate the authentication. With that in mind, I'm not sure...