Matthew Riley

Mixing `datetime.now()` and `datetime.utcnow()` may cause surprising comparisons

5

[`datetime.now()`](https://docs.python.org/3/library/datetime.html#datetime.datetime.now) and [`datetime.utcnow()`](https://docs.python.org/3/library/datetime.html#datetime.datetime.now) both return _naive_ (non-timezone-aware) `datetime` instances. Comparing instances from the two can produce meaningless results unless the server happens to be running in UTC. referencing the [Python...

With the [2017-04-28 release of CloudFormation](http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html), the `AWS::ECS::Service` resource now supports the `PlacementConstraints` and `PlacementStrategies` properties. `PlacementConstraints` seems very useful for the case where an N-task service is scheduled on...

Function calls still possible, thanks to comments

1

Per [this HN comment](https://news.ycombinator.com/item?id=17216352): >> Additionally, (() => 5)() doesn't work because we don't allow open and close parens next to each other. > > Not really, I can write...

Building Carbon on Windows without WSL

22

Building on Windows is low priority but it may be helpful to have a common place where we keep track of known problems. The first problem I hit was https://github.com/google/llvm-bazel...

Tests use invalid Curve25519 private keys

4

See also: https://github.com/WhisperSystems/libsignal-protocol-c/issues/15. `RatchetingSessionTest` and `RootKeyTest` each include an invalid Curve25519 private key where the first byte isn't divisible by 8 ([here](https://github.com/WhisperSystems/libsignal-protocol-java/blob/master/tests/src/test/java/org/whispersystems/libsignal/ratchet/RatchetingSessionTest.java#L176-L182) and [here](https://github.com/WhisperSystems/libsignal-protocol-java/blob/master/tests/src/test/java/org/whispersystems/libsignal/ratchet/RootKeyTest.java#L35-L41)). The Curve25519 functions have code to...

Displayable fingerprint computation depends on platform character set

1

[This call to `String.getBytes()`](https://github.com/WhisperSystems/libsignal-protocol-java/blob/1b2be846be35a90eb3b3e61f8b59676de83e4455/java/src/main/java/org/whispersystems/libsignal/fingerprint/DisplayableFingerprint.java#L65) should probably be replaced with `getBytes(StandardCharsets.UTF_8)` or `getBytes(Charset.forName("UTF-8"))`. Thankfully this seems to default to UTF-8 on Android anyway, though it's still worth being explicit: http://stackoverflow.com/questions/2207631/android-default-character-encoding

Ratchet tests use some invalid private keys

1

Two of the private keys in `test_ratchet.c` ([here](https://github.com/WhisperSystems/libsignal-protocol-c/blob/5d42bf0b9cba4d02c635ad9c21da9f5e2923ab03/tests/test_ratchet.c#L561-L565) and [here](https://github.com/WhisperSystems/libsignal-protocol-c/blob/5d42bf0b9cba4d02c635ad9c21da9f5e2923ab03/tests/test_ratchet.c#L197-L201)) aren't valid Curve25519 keys. Their first bytes aren't divisible by 8. I noticed this by uncommenting [these lines in curve25519-donna.c](https://github.com/WhisperSystems/libsignal-protocol-c/blob/0640b5accaf207aa51fbf83a7d2cd389c2bd24ad/src/curve25519/curve25519-donna.c#L860-L862),...

Make service health checks configurable

2

When a service specifies `protocol: "http"` for one of its ports, we should allow customization of at least: - the health check URL - the set of healthy responses Full...

The log group we create for a `cloud.Service` in AWS always has a retention of 1 day: https://github.com/pulumi/pulumi-cloud/blob/9c81b0be41447c7086e7c428a410df009c4a110f/aws/service.ts#L451-L454 We chose a small value because these logs were also diverted to...

Toolchain configuration can't produce stripped binaries

3

On macOS, at 9ed1c5cee9c3326178b80a35a8f217257971b410, with or without `.bazeliskrc` wired to `4.0.0`: ```bash $ bazelisk build //executable_semantics:executable_semantics.stripped [...] ERROR: /Users/mattdr/src/carbon-lang/executable_semantics/BUILD:11:10: Stripping executable_semantics/executable_semantics.stripped for //executable_semantics:executable_semantics failed: (Exit 1): llvm-strip failed: error executing...