Matt McShane

Results 6 comments of Matt McShane

> The only question I have is does the [comment of WithDialOptions](https://github.com/open-telemetry/opentelemetry-go/blob/4afe160b707d7e3623deaf013666c76832b78f01/exporters/otlp/otlptrace/otlptracegrpc/options.go#L136-L142) still make sense after this change? The comment was and remains sensible, the problem is that it was...

Added some additional options to the unit test to address the coverage drop. Should I squash these commits or do the maintainers do that at merge time?

Rework the overall approach as and when you see fit. The intention here is to only bring the behavior in line with the existing documentation. I'm only one datapoint but...

I suspect the problem is with this block here https://github.com/open-telemetry/opentelemetry-go/blob/ec33fe0fbcc2004b5ae280eac53faf8b59205a16/exporters/otlp/otlptrace/internal/otlpconfig/options.go#L106-L132 Those appends onto cfg.DialOptions end up _after_ the grpc dial options supplied through `otlptracegrpc.WithDialOption`, meaning that they take precedence. In...

@cretz I just landed #3231 which also updates to 1.16. Sorry - I didn't see this PR until it was too late.

Note that there's a fair amount of threading TracerProviders into place here. The main contribution is in gocql/tracing.go and its associated unit test. We prefer this implementation to the one...