Matt McKay

Results 701 comments of Matt McKay
trafficstars

@arnavs @sglyon If you had time would you be willing to run the `jl` and `ds` projects on this branch of the extension and let me know if you spot...

- [ ] setup a PR for `lecture-source-py` updating config in `Makefile` to point to new `_images` and `_downloads` location for images and downloads - [ ] setup a PR...

thanks @sglyon I will work on a fix for this context.

@sglyon I have issued a small fix for the `http` issues you are having which checks for external links when parsing adjustment for absolute links in nested folder case. I...

@sglyon @arnavs would you have time to review this with the latest adjustment to see if they work for `datascience` and `julia`?

@AakashGfude if you had any time I would appreciate a review of this approach and implementation. This works well for our projects but not so well for other use cases...

- [ ] this is **not** compatible with `ipynb_pdf_constructor` so we should get `pdf` construction merged #211 before this PR.

thanks for testing @sglyon -- this is on hold for a week as we get `pdf` feature merged. Then we will revisit this PR.

## Testing - [x] check this works for `html` output - [ ] check this works for `pdf` output through `jupyterpdf`

- [ ] this breaks `JupyterPDFBuilder` ```bash Exception occurred: File "/home/qebuild/repos/sphinxcontrib-jupyter/sphinxcontrib/jupyter/writers/translate_all.py", line 206, in visit_image elif uri not in self.builder.image_library.keys(): AttributeError: 'JupyterPDFBuilder' object has no attribute 'image_library' ```