mmcdole

Results 61 comments of mmcdole

@sgodart greetings! I appreciate the further details, but I was really asking for a new unit test, if you could, along with the patch. They are specified with minimal feed...

I think we broke several tests in https://github.com/mmcdole/gofeed/pull/202 . We need to fix this. That PR was very necessary to fix concurrency issues, but it looks like we busted base/relative...

@cristoper I don't know if you'd have a hot minute to check out the broken tests + relative URL handling? Did we just miss updating some places where we parse...

Thank you! Appreciate you @cristoper

![image](https://github.com/mmcdole/gofeed/assets/3767096/2445db64-6a6e-46fc-84bc-c064f282a4ab) I think we are back to green thanks to @cristoper !

Should I also consider handling custom elements within other elements? Like, within an `` element for example? Should each child struct have a customelement or map?

We also have our `extension` capability that parses arbitrary extensions. Perhaps we should get rid of the `CustomElement` idea and just tweak the extensions capability so it will parse anything,...

I just ran into this same problem. Things like `[rootXML child:@"channel.itunes:subtitle"].text;` don't work.

Yea, I see the issue with how we are calling `parseText` when we encounter an unknown tag, which is attempting to decode the element, which will fail if the the...

This is a great idea. I also am keen on introducing a config object, and putting some other things in there as well like user agent, proxy, strictness settings. We...