mmarton issues

Results 12 issues of


                                            mmarton

Not possible to use encore without warnings

It's not a serious problem, just an annoying thing. :) If I add encore to my package.json as a devdependency i get the warning: > Webpack is already provided by...

Precedence of ?? operator

Hi! This might be a bug: The precedence of ?? is not the same in twig as it is in php. > php: $x = 'a'; var_dump(null ?? $x.'_1'); //...

Contradicting info about bundle resource loading

Hi! in https://symfony.com/doc/current/bundles/best_practices.html#resources it sais that > If the bundle references any resources (config files, translation files, etc.), don’t use physical paths (e.g. `__DIR__/config/services.xml`) but logical paths (e.g. `@AcmeBlogBundle/config/services.xml`). The...

Call to function array_is_list() with will always evaluate to true.

Hi! As you can se there is a false positive issue in the link: https://phpstan.org/r/4a61f25b-34eb-4935-a054-868192f50aea ps: if you know a better way to check if an array is already sorted...

cyclomatic complexity of ternary/null coalescing in control structures

**Describe the bug** This might not be a bug, I'm just curious of your opinion After https://github.com/squizlabs/PHP_CodeSniffer/issues/3469 multiple part of my code is reporting too much cyclomatic complexity. i have...

Awaiting Feedback

Return type conflict in UploadedFileInfo

Hi! There is a type conflict here: https://github.com/antishov/StofDoctrineExtensionsBundle/blob/master/Uploadable/UploadedFileInfo.php#L29 the implemented interface returns string|null https://github.com/doctrine-extensions/DoctrineExtensions/blob/main/src/Uploadable/FileInfo/FileInfoInterface.php#L31 and the used UploadedFile class returns int|false (inherited from SplFileInfo) https://www.php.net/manual/en/splfileinfo.getsize.php At the docs there is...

Translatable classes not working with orm lazyGhostObjects enabled

Hi! `enable_lazy_ghost_objects: true` became the default config for doctrinebundle https://github.com/symfony/recipes/pull/1140 With it turned on I got this error from any translatable entity: ``` Proxies\__CG__\...\Entity\PageTranslation::createLazyGhost(): Argument #1 ($initializer) must be of...

mmarton