Matthew Madson
Matthew Madson
@ssilverman thanks for being so engaged. Apologies for not having the time to follow up yet. I'd love to have a conversation but honestly I'm not an expert on the...
Apologies for being soo terse, I was in a bit of a rush but I wanted to make sure I could track the issue. Pippo looks very promising. I've evaluated...
> Thanks for the PR! Do you think we can add tests to prevent future regressions? I'll take a crack at it, sure.
> Thanks for the PR! Do you think we can add tests to prevent future regressions? @ardatan The response-cache plugin does not have a tests folder or any tests defined...
> > Thanks for the PR! Do you think we can add tests to prevent future regressions? > > @ardatan The response-cache plugin does not have a tests folder or...
> It seems integration tests are not failing which is ok for now. Let's merge this, then we can think of individual unit tests later on. Thanks for the PR!...
turns out the main problem here is that function constructors do not inherit lexical scope. Needed to pass context as an arg to resolve things. See attached PR for a...
getNumTokens can refill the bucket following the tryConsume resulting in the following inconsistent headers: Capacity: 100 Cost: 50 Remaining: 100 ...